Wireshark-bugs: [Wireshark-bugs] [Bug 7708] Correcting a few fields in SDH dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 17 Sep 2012 05:01:13 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7708

Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexis.lagoutte@xxxxxxxxx

--- Comment #6 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2012-09-17 05:01:12 PDT ---
Thanks Andrew for the patch but there is a reason for octet b2 not use
proto_tree_add_item ? 
Also his lines is not needed (detect dead assignment by Clang) :
     b2  = 0;
     b2  = tvb_get_guint8(tvb, 0+(4*level*COLUMNS)) << 16;
     b2  = tvb_get_guint8(tvb, (1*level)+(4*level*COLUMNS)) << 8;

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.