Wireshark-bugs: [Wireshark-bugs] [Bug 7729] Full support of RFC2428 in FTP dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 16 Sep 2012 05:16:02 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7729

Jaap Keuter <jaap.keuter@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9154|review_for_checkin?         |review_for_checkin-
              Flags|                            |

--- Comment #3 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2012-09-16 05:16:01 PDT ---
Comment on attachment 9154
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=9154
Patch that implements RFC2428 support

You cannot do this:

+    addr->data = (void*) &ipv4_address;

or this

+    addr->data = (void*) words;

and expect the data to be there when the storage goes out of scope.

Also how it this code protected against buggy packets? Did you fuzztest this
code?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.