Wireshark-bugs: [Wireshark-bugs] [Bug 6527] corba dissector generator improvement
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 4 Sep 2012 10:36:23 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6527

Pascal Quantin <pascal.quantin@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pascal.quantin@xxxxxxxxx

--- Comment #18 from Pascal Quantin <pascal.quantin@xxxxxxxxx> 2012-09-04 10:36:22 PDT ---
(In reply to comment #17)
> Comment on attachment 9056 [details]
> Replace process_RequestOperation macro by a function
> 
> These dissectors are all supposedly auto-generated from idl2wrs.  Shouldn't
> patches be made against idl/* and then idl2wrs be re-run?

Actually my patch also includes a modification of wireshark_gen.py that is used
by idl2wrs. I just tried it and the files auto generated are equivalent to the
hand modified files. So the modifications will not be lost at the next
generation.
If Alexis confirms the improvement (and I expect it should), I will commit it.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.