Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 4141] Reassemble.c leaks memory for GLIB > 2.8

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4141

--- Comment #19 from Bill Meier <wmeier@xxxxxxxxxxx> 2012-09-04 10:22:06 PDT ---
(In reply to comment #18)
> (In reply to comment #5)
> 
> >       Also note that currently for free_all_reassembled_fragments()
> >       that the 'key_arg' points to se_alloc'd memory which has already
> >       been freed.
> 
> 
> > For the reassembled_table I think we'll need to change the key to be slice
> > allocated 
> 
> As Anders suggested, I'm going to change the reassembled_table keys to be slice
> allocated (even tho not strictly required) and then free them appropriately.
> 
> reassembled_table_init() is currently working (when freeing entries in the
> hash) because the invalid keys are never actually referenced but it's never a
> good thing to have dangling pointers.

Committed in SVN #44382

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.