Wireshark-bugs: [Wireshark-bugs] [Bug 7680] Added L2TPv3 control message authentication checking
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 30 Aug 2012 04:52:54 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7680

Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darkjames-ws@xxxxxxxxxxxx

--- Comment #8 from Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> 2012-08-30 04:52:54 PDT ---
Quick review:

(In reply to comment #3)
> Created attachment 9030 [details]
> Split sha1_hmac for incremental use

For consistency: s/sha1_hmac_starts/sha1_hmac_init/g ?

(In reply to comment #5)
> Created attachment 9032 [details]
> Add L2TPv3 control message authentication check

se_alloc() never returns NULL.
Also I don't see much sense for gotos in this patch, could you remove it?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.