Wireshark-bugs: [Wireshark-bugs] [Bug 7654] Add features to the Locator/ID Separation Protocol (
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 22 Aug 2012 03:21:45 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7654

--- Comment #10 from Pascal Quantin <pascal.quantin@xxxxxxxxx> 2012-08-22 03:21:44 PDT ---
(In reply to comment #9)
> Created attachment 8989 [details]
> LISP control packet dissector updates (v2)
> 
> Please consider adding to the tree this updated version of the patch.

Looks good to me with two small things:
- ENC_BIG_ENDIAN -> ENC_NA change for hf_lisp_xtrid (already changed locally)
- does Instance ID dissection in dissect_lcaf_iid deserves a real hf variable
instead of a proto_tree_add_text? Maybe being able to filter is is completely
useless

I'm waiting your feedback on Instance ID before committing.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.