Wireshark-bugs: [Wireshark-bugs] [Bug 7493] Dissector for the Parrot AR Drone
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 23 Jul 2012 05:04:53 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7493

--- Comment #11 from Martin Kaiser <wireshark@xxxxxxxxx> 2012-07-23 05:04:52 PDT ---

one more suggestion: 

at the beginning of dissect_ar_drone(), you check if the packet is actually for
your protocol and return if not.

You should change dissect_ar_drone() to return int and return the number of
bytes your dissector handled. Doing this, a caller can see if a packet was
processed by your dissector or rejected. See dissect_dvbci() and many others
for an example.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.