https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3203
Michael Mann <mmann78@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #5008|review_for_checkin? |review_for_checkin-
Flags| |
--- Comment #17 from Michael Mann <mmann78@xxxxxxxxxxxx> 2012-07-22 17:06:44 PDT ---
Comment on attachment 5008
--> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5008
Updated Patch
Some initial comments after a review:
1. Update cell_keys_list to UAT instead of formatted string
2. Has LibCrypt been updated with the necessary support for AES-CTR mode? Are
the packet-ssl-utils.[ch] updates still necessary?
3. Patch contains a bunch of unnecessary files. It should just be
packet-tor.c, packet-ssl-utils.[ch], (if necessary), and the updated makefiles
to include packet-tor.c
4. hf_tor_version should be added for the "typo" of the second hf_tor_length,
and both could be added as proto_tree_add_item()s
5. Use proper encoding macros for proto_tree_add_item() (fix-encoding-args.pl
can help)
6. Cleanup noted memory leaks.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
