Wireshark-bugs: [Wireshark-bugs] [Bug 7493] Dissector for the Parrot AR Drone
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 21 Jul 2012 09:54:05 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7493

Martin Kaiser <wireshark@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wireshark@xxxxxxxxx

--- Comment #4 from Martin Kaiser <wireshark@xxxxxxxxx> 2012-07-21 09:54:04 PDT ---
Hi,

two small comments

$ ./tools/checkAPIs.pl  epan/dissectors/packet-ar_drone.c 
Warning: epan/dissectors/packet-ar_drone.c does not have an SVN Id tag.

you should have $Id$ near the top of the source file
(closing $ seems to be missing)

Port 5556 is not officially assigned to your protocol? You should make the port
number configurable, see e.g. packet-icep.c. My understanding is that if your
protocol has no officially assigned port, the default should be 0.(Can others
confirm this?)

Hope this helps, I don't have more time now...

   Martin

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.