Wireshark-bugs: [Wireshark-bugs] [Bug 7428] Wireshark does not dissect NEGOEX, The Extended GSS-
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 3 Jul 2012 14:00:23 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7428

Pascal Quantin <pascal.quantin@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pascal.quantin@xxxxxxxxx

--- Comment #5 from Pascal Quantin <pascal.quantin@xxxxxxxxx> 2012-07-03 14:00:22 PDT ---
Hi Richard,

a few remarks concerning your patch:
- please use _U_ instead of __attribute__((unused)) so as to be portable across
platforms
- The "The" in the protocol name seems a bit strange to me. Is "Extended
GSS-API Negotiation Mechanism" enough?
- why use the volatile keyword for variables not inside and outside of a TRY
block ? Did I miss something ?
As you seem to be actively working on the dissector, should we wait a bit
before integrating it so as to get a more up-to-date version ?

Thanks,
Pascal.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.