Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 7407] New: Art-Net ESTA manufacturer codes are not labelled after dissection

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7407

           Summary: Art-Net ESTA manufacturer codes are not labelled after
                    dissection
           Product: Wireshark
           Version: 1.4.4
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Trivial
          Priority: Low
         Component: Dissection engine (libwireshark)
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: gareth.young@xxxxxxxxxxx


Created attachment 8684
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8684
Art-Net OEM manufacturer codes for 1.4be specification.

Build Information:
Version 1.4.4 (SVN Rev 36110 from /trunk-1.4)

Copyright 1998-2011 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (32-bit) with GTK+ 2.16.6, with GLib 2.22.4, with WinPcap (version
unknown), with libz 1.2.3, without POSIX capabilities, without libpcre, with
SMI
0.4.8, with c-ares 1.7.1, with Lua 5.1, without Python, with GnuTLS 2.8.5, with
Gcrypt 1.4.5, with MIT Kerberos, with GeoIP, with PortAudio V19-devel (built
Mar
 1 2011), with AirPcap.

Running on 64-bit Windows 7 Service Pack 1, build 7601, with WinPcap version
4.1.2 (packet.dll version 4.1.0.2001), based on libpcap version 1.0 branch
1_0_rel0b (20091008), GnuTLS 2.8.5, Gcrypt 1.4.5, without AirPcap.

Built using Microsoft Visual C++ 9.0 build 21022

--
Wireshark currently only interprets the ESTA manufacturer code from a dissected
Art-Net packet for Artistic Licence.  It would be useful if these packets could
be labelled.

This requires the population of:

static const value_string artnet_esta_man_vals[]{}

within packet-artnet.c

The official list of ESTA manufacturer IDs can be found at the following
website:
http://tsp.plasa.org/tsp/working_groups/CP/mfctrIDs.php 

It may be worth noting in the code that versions of the Art-Net protocol prior
to 1.4be (19/12/2011) defined the ESTA code as an int16, which has now changed
to two int8 fields in the order of EstaHigh, EstaLow.  As a result, I suspect
devices that output this field using an older version of the specification may
now report the ESTA code backwards (wrong endianness).  I'm not sure if this
can be easily tested for in code or if it will be the case but is worth being
aware of.  

Also, please update:
static const value_string artnet_oem_code_vals[]

I have attached the most recent file from the SDK that contains the required
and most recent OEM values as the list currently in the source code is quite
old.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.