Wireshark-bugs: [Wireshark-bugs] [Bug 6844] Universal Alcatel Protocol - Reloaded
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 9 Jun 2012 12:00:08 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6844

--- Comment #29 from Bill Meier <wmeier@xxxxxxxxxxx> 2012-06-09 12:00:08 PDT ---
(In reply to comment #27)
> In str_to_ipaddr() 'p' can point after NUL.
> 
> for (i = 0; i < 4; i++) {
>   value = 0;
>   while (*p != '.' && *p != '\0') {  <---- while-loop will terminate when *p ==
> 0
>     value = value * 10 + (*p - '0');
>     p++;
>   }
>   /* ... */
>   p++; <--- p points after NUL.
> }
> 
> Lars please fix or just use inet_aton()/sscanf().


Fixed [by using inet_pton()].

Also: handling of an invalid IP address improved.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.