Wireshark-bugs: [Wireshark-bugs] [Bug 6986] Updating the RPL SRH dissector and implementing RPL
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 29 May 2012 21:36:35 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6986

Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darkjames-ws@xxxxxxxxxxxx

--- Comment #12 from Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> 2012-05-29 21:36:34 PDT ---
When comparing the addresses please use memcmp(),

bad:

+   /* Compare the addresses */
+  for(j = 0; j < 16; j++) {
+    if(addr.bytes[j] != tempAddr.bytes[j]){
+      different = 1;
+      break;
+    }
+  }
+  if(different == 0){

good:

if (memcmp(addr.bytes, tempAddr.bytes, 16) == 0) {

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.