Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 7279] WiMax\M2M Dissectors failure. Worked in v1.0.15, fails under 1.6.8 Win32

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7279

Austin <chuckbubba777@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Austin <chuckbubba777@xxxxxxxxxxx> 2012-05-23 14:36:51 PDT ---
Found it!

Started merging changes, other than the "FALSE" to "ENC_BIG_ENDIAN" and\or
"ENC_NA", from the 1.7.2 into 1.6.8.

It is in msg_ulmap.c.  Around line 1963
-------- v1.6.8 ------------- BROKEN
    ti = proto_tree_add_protocol_format(base_tree,
proto_mac_mgmt_msg_ulmap_decoder, tvb, NIBHI(offset,length), "Compressed
UL-MAP");

-------- v1.7.2 ------------- WORKS!!
    ti = proto_tree_add_protocol_format(base_tree,
proto_mac_mgmt_msg_ulmap_decoder, tvb, NIBHI(offset,length-offset), "Compressed
UL-MAP (%u bytes)", NIB_ADDR(length-offset));

Changing the NIBHI(offset,length) to NIBHI(offset,length-offset) is what makes
it work!!

This isn't the first time one of the #defines in the WiMax dissector has caused
all kinds of problems.  The old BIT_BITS used have pletohs(l) instead of
plntohs(l).

Thanks for all the quick responses.
Austin

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.