Wireshark-bugs: [Wireshark-bugs] [Bug 7224] Custom model for packet details
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 9 May 2012 00:02:54 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7224

--- Comment #3 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2012-05-09 00:02:53 PDT ---
(In reply to comment #1)
> Created attachment 8368 [details]
> Clear treestore before freeing edt
> When building current data for packet details treeview we store two things.
> - Generated string with item label
> - Pointer to node field_info structure
> After epan_dissect_{free, cleanup} pointer to field_info node is no longer
> valid so we should store before freeing.
> This is not *critial* in current version cause even if gdk/gtk thread fire up 
> cell renderer is using generated string.
> I can commit it by myself, just need someone to review ;-)

Hi,
Looks good to me.
Regards
Anders

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.