Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 7197] New: Accelerators for "Expand Subtree", "Expand All" and "Collapse All"

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7197

           Summary: Accelerators for "Expand Subtree", "Expand All" and
                    "Collapse All" are missing
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: Low
         Component: Wireshark
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: a.pontus@xxxxxxxxx


Build Information:
> wireshark -v
wireshark 1.7.2 (SVN Rev Unknown from unknown)

Copyright 1998-2012 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GTK+ 2.12.12, with Cairo 1.2.4, with Pango 1.17.5, with
GLib 2.15.6, with libpcap, with libz 1.2.3, with POSIX capabilities (Linux),
with SMI 0.4.5, without c-ares, without ADNS, without Lua, without Python, with
GnuTLS 1.4.1, with Gcrypt 1.4.4, without Kerberos, without GeoIP, without
PortAudio, with AirPcap.

Running on Linux 2.6.18-164.el5, with locale en_US.iso88591, with libpcap
version 0.9.4, with libz 1.2.3, GnuTLS 1.4.1, Gcrypt 1.4.4, without AirPcap.

Built using gcc 4.1.2 20080704 (Red Hat 4.1.2-46).

> git log -n 1 HEAD
commit 0fe7859ca43d71b85dc132d93fe288631b559d2d
Author: Michael Tüxen <tuexen@xxxxxxxxxxxxxx>
Date:   Wed Apr 25 16:05:29 2012 +0000

    Fix locking problem.

    svn path=/trunk/; revision=42235

--
The accelerators or keyboard shortcuts for "Expand Subtree", "Expand All" and
"Collapse All" does not work any more. The shortcuts are very useful for doing 
fast and efficient analysis of traces. I would hate for this to be gone :)

According to the User Guide it should be there:
http://www.wireshark.org/docs/wsug_html_chunked/ChUseViewMenuSection.html

I think I have traced down to which commit this was changed and I am not sure
if it was done intentionally. It seems to be part of some code restructuring:

commit e6bd9d1a8c3b691f342bf7bc9b3ea668ec6a7a16
Author: Bill Meier <wmeier@xxxxxxxxxxx>
Date:   Wed Sep 21 18:55:03 2011 +0000

    Whitespace cleanup:
     Use consistent indentation;
     Convert "4 space tabs" to spaces;
     Remove trailing whitespace.

    svn path=/trunk/; revision=39082

diff --git a/gtk/menus.c b/gtk/menus.c
deleted file mode 100644
index 8943e0e..0000000
--- a/gtk/menus.c
+++ /dev/null
...
-    {"/View/E_xpand Subtrees", "<shift>Right", GTK_MENU_FUNC(expand_tree_cb),
0, NULL, NULL,},
-    {"/View/_Expand All", "<control>Right", GTK_MENU_FUNC(expand_all_cb),
-                       0, NULL, NULL,},
-    {"/View/Collapse _All", "<control>Left", GTK_MENU_FUNC(collapse_all_cb),
-                       0, NULL, NULL,},
...

diff --git a/ui/gtk/main_menubar.c b/ui/gtk/main_menubar.c
new file mode 100644
index 0000000..5ecaca2
--- /dev/null
+++ b/ui/gtk/main_menubar.c
...
+   { "/View/ExpandSubtrees",        NULL,                   "Expand Subtrees",
     NULL,                   NULL,           G_CALLBACK(expand_tree_cb) },
+   { "/View/ExpandAll",             NULL,                   "Expand All",     
     NULL,                   NULL,           G_CALLBACK(expand_all_cb) },
+   { "/View/CollapseAll",           NULL,                   "Collapse All",   
     NULL,                   NULL,           G_CALLBACK(collapse_all_cb) },
...

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.