Wireshark-bugs: [Wireshark-bugs] [Bug 7038] NASDAQ MOLD UDP 64 Dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 23 Apr 2012 10:18:05 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7038

--- Comment #10 from Evan Huus <eapache@xxxxxxxxx> 2012-04-23 10:18:05 PDT ---
(In reply to comment #9)
> I look good !
> Only 2 items :
> The fix-encodings script found 2 errors :
> ./tools/fix-encoding-args.pl epan/dissectors/packet-moldudp*
> epan/dissectors/packet-moldudp64.c:  FT_BYTES:        
> proto_tree_add_item(blk_tree, hf_moldudp64_msgdata,            tvb, offset,
> real_msglen, [[ENC_BIG_ENDIAN]-->[ENC_NA]]);
> epan/dissectors/packet-moldudp.c:  FT_BYTES:        
> proto_tree_add_item(blk_tree, hf_moldudp_msgdata,            tvb, offset,
> real_msglen, [[ENC_LITTLE_ENDIAN]-->[ENC_NA]]);

Whoops, yes, will fix those.

> Also about sequence number in Message Block, it is a generated number ?
> It is possible to use the macro PROTO_ITEM_SET_GENERATED ?

Yes it's generated - I didn't know that macro existed. Will take a look.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.