Wireshark-bugs: [Wireshark-bugs] [Bug 7141] Two bad NULL checks in airpcap_loader.c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 18 Apr 2012 11:21:33 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7141

--- Comment #3 from Evan Huus <eapache@xxxxxxxxx> 2012-04-18 11:21:33 PDT ---
(In reply to comment #2)
> Committed revision 42136.
> 
> Speaking of style(from another bug) I find this
> +    if (NULL == if_info) 
> very ugly, I prefere
> +    if (if_info == NULL)

(NULL == if_info) throws a compiler error if I typo the == as an =, where as
(if_info == NULL) does not. I agree it's uglier, but it is safer. To each his
own I guess.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.