Wireshark-bugs: [Wireshark-bugs] [Bug 7136] HIP dissector: HIT_SUITE_LIST parameter from HIPv2
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 18 Apr 2012 02:23:44 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7136

Francisco Vidal Meca <fvidalmeca@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8259|                            |review_for_checkin?
              Flags|                            |

--- Comment #1 from Francisco Vidal Meca <fvidalmeca@xxxxxxxxx> 2012-04-18 02:23:44 PDT ---
Created attachment 8259
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8259
Patch proposal to allow HIT_SUITE_LIST parameter dissection

The patch allows for HIT_SUITE_LIST parameter dissection, but needs a FIX.

As described in the specification, the Suite ID takes only the four higher
order bits in the ID field. But this is done by assigning the whole value of
the field instead of ignoring the four low order bits. Hence the value shown in
the dissector is shifted 4 bits, instead of 1 showing 16 and so on. The names
show up correctly though.

A four bit shift is needed in the value, also changing the mapping of the
values to string to reflect that shift.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.