Wireshark-bugs: [Wireshark-bugs] [Bug 7085] Buildbot crash output: fuzz-2012-04-14-9084.pcap
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7085
Evan Huus <eapache@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #35 from Evan Huus <eapache@xxxxxxxxx> 2012-04-17 10:41:04 PDT ---
(In reply to comment #34)
> 1. adding new conversations is _fast_ because the frames have increasing frame
> number (even though merging files may turn out to be slow)
> 2. looking up conversations is _slow_ because the function
> conversation_lookup_hashtable() has to traverse the chain list for each and
> every frame...
>
> my proposal: cache the last found conversation; store it into the hash chain
> list head (it gets 10 times faster or maybe even more). I have a patch for it.
> new bug report?
Yes a new bug report ('enhancement' priority) would be appropriate. If you
could attach your test captures (or host them somewhere else and provide a
link) on the new report, that would be good too.
I'm a bit surprised though - my expectation would be that for sane captures,
conversation_lookup_hashtable() would be able to skip to the end of the list
using the 'last' pointer just like adding new conversations does. The code is
there in conversation_lookup_hashtable(), so I'm curious why it's not being
exercised.
We can continue this conversation on the new bug.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
