Wireshark-bugs: [Wireshark-bugs] [Bug 6926] VoIP Calls Graph Analysis: Elements not sorted by Ti
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6926
Cristian Constantin <const.crist@xxxxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |const.crist@xxxxxxxxxxxxxx
--- Comment #5 from Cristian Constantin <const.crist@xxxxxxxxxxxxxx> 2012-04-11 09:53:23 PDT ---
(In reply to comment #2)
> For whath it's worth, this bug was introduced with the speedup of voip/sip call
> flow http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=40878
> and the problem is in voip_calls.c RTP_packet_draw().
> Perhaps the code should be simplified and
> the_tapinfo_struct.graph_analysis->list sorted after all info has been added.
> Anders
cristian: hi! any idea how could the "big" final sort (provided by the patch)
be avoided?
would an insertion sort on the actual list be better (taking into account that
much of the data is already sorted)?
otoh, since both in the case of sip and in the case of rtp the frames are
_prepended_, how comes that that reversing works only for the sip ones??
thanks!
cristian
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
