Wireshark-bugs: [Wireshark-bugs] [Bug 7042] The MSISDN is not seen correctly in GTP packet
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 8 Apr 2012 06:43:13 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7042

--- Comment #5 from Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> 2012-04-08 06:43:12 PDT ---
(In reply to comment #4)
> Fixed in revision 41979.

Pascal, I still don't like msisdn_to_str (nor id_to_str) functions.
When nibble is outside BCD range (i.e. 0xa-0xf) what should be written to
output buffer?

Right now content is determinated by previous call.
Maybe instead of:
   j++
do:
   str[j++] = ' ';

or we should throw exception or what?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.