Wireshark-bugs: [Wireshark-bugs] [Bug 7020] Review use of proto_tree_add_text in packet-eap.c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 3 Apr 2012 19:10:17 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7020

Nick Lowe <nick.lowe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8149|                            |review_for_checkin?
              Flags|                            |

--- Comment #9 from Nick Lowe <nick.lowe@xxxxxxxxx> 2012-04-03 19:10:16 PDT ---
Created attachment 8149
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8149
Convert EAP-IDENTITY, EAP-NOTIFY and EAP-MD5 to use proto_tree_add_item().

Really ought to get some sleep! :( Take three... Sorry!

Convert EAP-IDENTITY, EAP-NOTIFY and EAP-MD5 to use proto_tree_add_item().

Second patch covering the identity, notify and MD5 EAP types.
Also disambiguated the EAP-TLS length name and tidied.

eapid, eapnotify, eapmd5.value_size and eapmd5.value are new.

I am looking at the LEAP EAP type now, is there a security/crash issue with it
blindly passing the count to tvb_bytes_to_str() having previously just read
it in without any sanity checks?

(Minor change from obsoleted patches -> eapid to eapid.identity and eapnotify
to
eapnotify.notification)

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.