Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6878] Overhaul of tvb_get_bitsxx() functions

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6878

Chris Maynard <christopher.maynard@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #9 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2012-03-20 18:18:42 PDT ---
(In reply to comment #5)
> Committed revision 41226.

Coverity reveals a nasty bug in _tvb_get_bits64() with this commit that seems
to have created quite a number of "OVERRUN STATIC" CID's.

Basically, bit_mask8[] is directly indexed using "total_no_of_bits" at line
1786 of epan/tvbuff.c:

value = (tvb_get_guint8(tvb, octet_offset) >> right_shift) &
bit_mask8[total_no_of_bits];

... but total_no_of_bits can be larger than 8, thus for each occurrence, a CID
"OVERRUN STATIC" is generated.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.