Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6792] New dissector for Ericsson OM2000 A-bis OML

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6792

Bill Meier <wmeier@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #8 from Bill Meier <wmeier@xxxxxxxxxxx> 2012-03-16 07:36:22 PDT ---
After further review, I noted that the FT_BOOLEAN hf[] entries 'display' and
'bitmask' fields were incorrectly used.

The correct usage:

1. display=<width of the "parent field">, bitmask=<mask>

   Example: ..., FT_BOOLEAN, 8, NULL, 0x1c, ...
   . . . 1 1 1 . .  Foo: True

   Most of the time the width is a multiple of 8 so that one can see
   which bits of the byte(s) comprise the field. 

2. display=BASE_NONE, bitmask=0x00

   In this case, the value fetched from the tvb is tested for True/False.

Note that the initial data fetched from the tvb (before applying the any
bitmask) is determined by the offset & length specified in the
proto_tree_add_item() statement.

I've fixed a few cases where it seemed clear as to what was intended.

I've marked other cases with an XXX comment for your feedback.

For the changes committed see:
 http://anonsvn.wireshark.org/viewvc?revision=41612&view=revision

Please provide a patch with the correct bitmasks & etc for the cases marked
with XXX.

Thanks

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.