Wireshark-bugs: [Wireshark-bugs] [Bug 6874] New dissector: performance co-pilot protocol
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6874
--- Comment #5 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2012-03-04 03:08:40 PST ---
Hi,
(In reply to comment #4)
> Created attachment 7944 [details]
> Updated patch for inclusion
>
> Thanks for the review so far
>
> I've uploaded a new patch for review which obsoletes the existing two (is this
> the preferred way or would you prefer patch sets?).
Prefer new patch !
>
> I've changed all instances proto_tree_add_item to use the ENC_* constants.
> Regarding the Clang warnings, I've changed most of the decoding routines to
> return void as the returned offset is not used again. I've still elected to
> increment the offset after it has passed through the dissecting routines purely
> for consistency sake. I did not have any warnings compiling this using GCC
> 4.6.2.
I will check !
>
> Regarding the use of proto_tree_add_int/float it seems like I needed to do this
> to dissect non-contiguous bytes in the packet but keep the values stored under
> the same tree (see comment at line 928 of packet-pcp.c).
>
> Depending on the "valfmt type", the 4 bytes stored after the instance (line 912
> of packet-pcp.c) is either the value _or_ a pointer to further in the packet of
> another data structure which contains the value.
There is no problem ! proto_tree_add_item can be used
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
