Wireshark-bugs: [Wireshark-bugs] [Bug 6881] Support for MPLS Packet Loss and Delay Measurement,
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6881
--- Comment #2 from FF <francesco.fondelli@xxxxxxxxx> 2012-02-29 11:41:13 PST ---
(In reply to comment #1)
> Hi Francesco,
Hi Alexis,
thanks for your time and review.
> it is possible to attach a sample of packet with RFC6374 ?
Yes, though I had to obfuscate it slightly. Please find it in
attach (mpls-pm-dlm-dm.pcap).
> the CheckAPI is not happy with packet-mpls-pm.c
> /tools/checkAPIs.pl epan/dissectors/packet-mpls-pm.c
> Warning: epan/dissectors/packet-mpls-pm.c does not have an SVN Id tag.
fixed in patch v2
> Error: epan/dissectors/packet-mpls-pm.c : Missing 'const': value_string
> pmt_vals[]
fixed in patch v2
> There is some warning with Clang compiler :
> packet-mpls-pm.c:715:5: warning: Value stored to 'rptf' is never read
> packet-mpls-pm.c:839:5: warning: Value stored to 'rptf' is never read
removed in patch v2
> Also there missing the modification for Cmake (epan/CMakeLists.txt)
added in patch v2
> Why not use proto_tree_add_item when there is uint64 ? (example :
> proto_tree_add_uint64_format(pm_tree, hf_mpls_pm_counter1, tvb,
> offset, 8,
> tvb_get_ntoh64(tvb, offset),
> "Counter 1 "
> "(B_TxP): %"G_GINT64_MODIFIER"u",
> tvb_get_ntoh64(tvb, offset));)
I wanted complete control over how the field and value would be represented
on the GUI tree... but I forgot to use it :-). In patch v2 I did it
properly (adding "packets"/"octets" unit after the values).
please consider it for inclusion.
thank you
ciao
FF
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
