Wireshark-bugs: [Wireshark-bugs] [Bug 6792] New dissector for Ericsson OM2000 A-bis OML
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 26 Feb 2012 09:32:39 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6792

Jörg Mayer <jmayer@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7767|review_for_checkin?         |review_for_checkin+
              Flags|                            |

--- Comment #3 from Jörg Mayer <jmayer@xxxxxxxxx> 2012-02-26 09:32:37 PST ---
Comment on attachment 7767
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7767
patch with ehdlc and om2000 dissectors

Committed revision 41195.

Remarks:
- packet-gsm_abis_om2000.c, function dissect_tss_mo_state could
  do this via bitfields instead of ..._uint_format. That way the individual
  elements could be made filterable.
- packet-gsm_abis_om2000.c, function dissect_om2k_mo has some undissected
  bytes (offsets 1 and 2). Is this intentional?
- packet-gsm_abis_om2000.c, function dissect_tss_mo_state returns the new
  offset, while all other functions return the number of bytes consumed

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.