Wireshark-bugs: [Wireshark-bugs] [Bug 3096] Ability to annotate packet captures
Date: Thu, 9 Feb 2012 08:38:16 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3096

--- Comment #24 from Martin Kaiser <wireshark@xxxxxxxxx> 2012-02-09 08:38:15 PST ---

Hi Anders,

> - How to make the data avilable (wtap), in the case of pcapng there is a couple
> of more peices of information that can be of interest.
>

ok

> - "Storing" the data, as Guy pointed out having it in the frame data structure
> carries an overhead as ther might be many packets. I contemplated using 
> pfd;          /**< Per frame proto data */
> 
> perhaps that's a better idea. I'd make it belong to the Frame dissector then.
>

I tried this, see attached patch

> - Presenting the data. Is "my way" better than the tooltip one or do we need
> someting entierly different? One could perhaps popup a new treeview with all
> comments like the expert info or add that as well?

I like your approach, it works with UTF-8 and allows filtering.

> 
> As for writing comments I have no idea how difficult that would be. from a GUI
> perspective we should probably add an "Edit comment" menu to the packet tree
> view popup.

and an "add comment" for packets without comments

Regards,

   Martin

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.