Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6807] RFC 4684 (Constrained Route Distribution for BGP/MPLS IP VPN) support

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6807

Daniel Ginsburg <dginsburg@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7789|0                           |1
        is obsolete|                            |
   Attachment #7789|review_for_checkin?         |
              Flags|                            |
   Attachment #7802|                            |review_for_checkin?
              Flags|                            |

--- Comment #4 from Daniel Ginsburg <dginsburg@xxxxxxxxx> 2012-02-09 05:07:11 PST ---
Created attachment 7802
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7802
Revised patch for RFC 4684 support

> Please also prefer proto_tree_add_item (and not proto_tree_add_text, it is not filereable...)

Currently other extended communities are handled with proto_tree_add_text. To
be consistent with that, I also use proto_tree_add_text instead of
proto_tree_add_item.

It makes sense to convert all of extended communities handling to
proto_tree_add_item to make it filterable, but it's not exactly related to the
problem the patch tries to solve. Maybe I can do it as separate submission.

> Also don't not use memcpy... use tvb_ function (See Readme.dev guide)

Fixed. I hope I got tvb memory management right. Please review.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.