Wireshark-bugs: [Wireshark-bugs] [Bug 6798] Add support for GMR-1 BCCH dissection
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 7 Feb 2012 23:46:57 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6798

--- Comment #10 from Sylvain Munaut <246tnt@xxxxxxxxx> 2012-02-07 23:46:55 PST ---
(In reply to comment #9)
> Have the changes to gsmtap been approved? 

Yes, here is the matching commit in libosmocore ("official" gsmtap.h)

http://cgit.osmocom.org/cgit/libosmocore/commit/include/osmocom/core/gsmtap.h?id=f84571d0f46845285b810a48679a554fb68ec278


> I've checked in the patches and #ifmatrix([[1, 2], [3, 4]])
> 0'd out incomplete code. You might want to tidy that up :-)

Oh damn, I wish you hadn't. The patch to fix the #if is gonna be messier than
the patch to fix the initial issue. (basically just add a gint dummy; in every
empty struct until someone writes dissection code for it). And as it is it may
compile but doesn't really do anything anyway.

I'll try to clean that up later today.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.