Wireshark-bugs: [Wireshark-bugs] [Bug 5575] Patch to fix memory leaks/errors in Lua plugin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 5 Feb 2012 20:05:19 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5575

--- Comment #21 from Tony Trinh <tony19@xxxxxxxxx> 2012-02-05 20:05:18 PST ---
Comment on attachment 7449
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7449
patch 5/6 Fix Lua Tap support.

I'm confused about the "tree" parameter added to the "listener.packet()"
callback. The tap would only need access to the "tree" if it were changing it
(e.g., adding items), but taps aren't meant to do that (only dissectors and
postdissectors can add to the tree).

It seems you introduced "tapdata" to read data from the proto_tree that was
added by a dissector, but that's exactly the purpose of the "Field" class. Does
it not help?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.