Wireshark-bugs: [Wireshark-bugs] [Bug 6758] Dissector for the Sony FeliCa Protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 24 Jan 2012 05:08:04 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6758

--- Comment #7 from Tyson Key <tyson.key@xxxxxxxxx> 2012-01-24 05:08:04 PST ---
(In reply to comment #6)
> Also a small comment
> There is some false positive with checkhf
> ERROR: NO ARRAY: epan/dissectors/packet-rfid-felica.c, hf_felica_req_codes
> ERROR: NO ARRAY: epan/dissectors/packet-rfid-felica.c, hf_felica_responses
> ERROR: NO ARRAY: epan/dissectors/packet-rfid-felica.c, hf_felica_commands
> ERROR: NO ARRAY: epan/dissectors/packet-rfid-felica.c, hf_felica_sys_codes
> 
> Don't start value_string by hf_... use felica_commands_type or
> hf_felica_commands_vals

Thanks, Alexis. 

Come to think of it, I should probably also update the MiFare dissector to
reflect that convention, when I get chance...

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.