Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6737] build fails in configure with GTK+ error

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6737

--- Comment #2 from njtaylor0101@xxxxxxxxx 2012-01-14 12:43:12 PST ---
(In reply to comment #1)
> Configure scripts are not written by hand, they're generated from configure.in
> by autoconf, so the patch can't be applied - there's nothing to which to apply
> it (the configure script isn't in SVN, and won't ever be in SVN, only the
> Wireshark source files from which it's generated, such as configure.in,
> acinclude.m4, etc., are).
> 
> This might be a consequence of the configure script being built on a system
> with GTK+ 2.x installed, or with an older version of it installed; the 2.x
> version of the configure macros might not understand that there's no GLib 3.x
> and that GTK+ 3.x works with GLib 2.

Both wirehark 1.6.5, and the nightly SVN-40442 used the configure file that is
in the source tarball, the configure script is used unaltered when building the
port on OpenBSD, apart from applying a set of patches only where necessary. It
is the configure.in generating configure for the source tarballs that is wrong.

configure.in has ----

if test "x$with_gtk3" = "xyes"; then
        AM_PATH_GTK_3_0(3.0.0,
        [
                CFLAGS="$CFLAGS $GTK_CFLAGS"
                CXXFLAGS="$CXXFLAGS $GTK_CFLAGS"
                AC_DEFINE(HAVE_GTK, 1, [Define to 1 if compiling with GTK])
        ], GTK_OK=no, gthread)

Defined here ---
aclocal-fallback/gtk-3.0.m4:dnl AM_PATH_GTK_3_0([MINIMUM-VERSION,
[ACTION-IF-FOUND [, ACTION-IF-NOT-FOUND [, MODULES]]]])

The modules, clearly are optional, so removing the gthread from AM_PATH_GTK_3_0
in configure.in should have the same effect as the patch to configure when used
to generate configure file for the source tarballs.

aclocal-fallback/gtk-3.0.m4 has this

  pkg_config_args=gtk+-3.0
  for module in . $4
  do
      case "$module" in
         gthread)
             pkg_config_args="$pkg_config_args gthread-2.0"
         ;;
      esac
  done

gthread is already checked later in configure.in as part of Glib-2.0, so
doesn't need checking with gtk+-3.0.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.