Wireshark-bugs: [Wireshark-bugs] [Bug 6702] Patch to support latest GTK+ MAC OS X integration
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6702
Jim Young <jyoung@xxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #7634| |review_for_checkin?
Flag| |
--- Comment #4 from Jim Young <jyoung@xxxxxxx> 2012-01-01 12:54:53 PST ---
Created an attachment (id=7634)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7634)
Proposed patch for improved GTK2 detection with cmake in jhbuild shell
Hello Jörg,
I had never touched cmake until yesterday. But I now understand why the fuss.
It sure is pretty. ;-)
I've attached a patch that replaces Wireshark's current
cmake/modules/FindGTK2.cmake with what is essentially your FindGTK3.cmake with
virtually all references of '3' replaced with '2'. I think using pkg-config
"to get the directories and then use these values in the FIND_PATH() and
FIND_LIBRARY() calls" is more robust than the GTK2 lib/include discovery code
in the current "FindGTK2.cmake".
But the new FindGTK2.cmake is somewhat naive; it doesn't even test for a
minimum GTK 2.x level! But hopefully it is a starting point for something
better.
With the replacement FindGTK2.cmake in place, running cmake and make within a
'jhbuild shell' built all of Wireshark's executables INCLUDING the wireshark
GUI itself. (yippee!)
NOTE: With the original FindGTK2.cmake in place, running cmake and make within
a 'jhbuild shell' will build all of Wireshark's executables BUT the wireshark
GUI itself! Because of my ignorance of cmake it was initially pretty
frustrating to find out why the wireshark GUI itself wasn't built. There was a
cmake message appeared claiming " -- GTK2_FOUND". But once I used cmake's
--trace option (e.g. cmake --trace ../wireshark) it helped me better
understand where all the magic files were being pulled from and what wasn't
really being found!
So to answer your question (challenge?) in Comment #3, I hope to be able to add
cmake support for using library gtkmacintegration and HAVE_GTKOSXAPPLICATION
over the next few days.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
