Wireshark-bugs: [Wireshark-bugs] [Bug 3984] r29723 optimization, if (cinfo->col_data[col] != cin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 23 Dec 2011 07:24:51 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3984

--- Comment #10 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2011-12-23 07:24:50 PST ---
(In reply to comment #9)
> (In reply to comment #7)
> 
> > We should fix these issues instead of trying to hide them. Things like these
> > only get worse with time. 
> A lot of dissectors are not in SVN and their authors often don't know all
> wireshark 'quirks', with val_str the problem may appear very rarely and for
> them fixing this bug will waste more time than they ever win by saving a little
> memory.  

> > > Moreover a lot of dissectors currently using col_add_str(..., val_to_str(...))
> > > could be move back to use col_set_str.
> > > It would save more memory, unknown values are or should be uncommon, and it
> > > would be faster.

I just noticed this bug report today.  Interesting.  I am wondering what the
other, more experienced core developers think about this.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.