Wireshark-bugs: [Wireshark-bugs] [Bug 6686] dissector for the bzr smart server protocol
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6686
--- Comment #9 from Jelmer Vernooij <jelmer@xxxxxxxxx> 2011-12-20 16:11:05 PST ---
(In reply to comment #7)
> Is the function dissect_structured necessary? It appears to do nothing more
> than call dissect_prefixed_bencode() and return its result.
No, it's indeed not really necessary - I've removed it.
I've also added a link to the protocol reference in the source and on the wiki.
(In reply to comment #6)
> It would be very helpful to include descriptions in the field descriptions (the
> FIELDDESCR field as shown in doc/README.developer):
> static hf_register_info hf[] = {
> { &hf_PROTOABBREV_FIELDABBREV,
> { "FIELDNAME", "PROTOABBREV.FIELDABBREV",
> FIELDTYPE, FIELDDISPLAY, FIELDCONVERT, BITMASK,
> "FIELDDESCR", HFILL }
> }
I've added a description to a couple of the fields where I could think of
something useful to add.
> For example, to those of us not familiar with Bazaar (or, apparently,
> BitTorrent) the term "Bencode" is unfamiliar.
As a follow-up patch, I hope to extract the bencoding code from
packet-bittorrent.c into packet-bencode.c and share that between both
dissectors.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
