https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5784
--- Comment #9 from Harald Welte <laforge@xxxxxxxxxxxx> 2011-12-10 01:06:51 PST ---
(In reply to comment #7)
> __attribute__ ((packed)) isn't portable--that's gotta go.
Oh yes, I keep getting about wireshark support for non-gcc compilers. Sorry.
> And I'm pretty uncomfortable with all this mucking around inside of
> value_string_ext's. AFAICS this is to use different value_strings for the same
> hf entry depending on a preference. Why not just use 2 hf's?
The problem with the various A-bis OML dialects (and we have more of them on
our schedule to submit) is:
* there are certain elements that are defined in the 12.21 spec
* a lot of those from 12.21 are used by many dialects
* each dialect adds their own ones (conflicting with other dialects)
* some dialects even override some of the 12.21 specified ones
The 'mucking around' is intended to avoid copy+paste style programming, where
the TS 12.21 standard elements would have to be copy+pasted across all the
dialects.
I'm happy to go for an alternative solution, as long as it avoids copy+pasting.
> Or use BASE_CUSTOM?
Interestingly I've never heard of it so far. After a quick look, it might be
useful. I'll try to modify the dissector to use this instead and report bag to
this ticket.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
