Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6645] Patch to add support for Windows Friendly Interface Names

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6645

--- Comment #1 from Guy Harris <guy@xxxxxxxxxxxx> 2011-12-03 09:27:13 PST ---
Note that this *really* belongs in WinPcap, but a workaround in Wireshark until
WinPcap is fixed is probably OK.

However, is there any reason why, if an interface as an Interface Friendly
Name, that should not just be used as the description, rather than what WinPcap
currently supplies as the description?  That would be a simpler fix, and would
probably mean that *only* capture-pcap-util.c and dumpcap.c need to be changed.

Also, there is no guarantee that the interface description on UN*X won't have
spaces in it, so

+#ifdef _WIN32      
+      g_string_append_printf(str, "'%s'", interface_opts.descr);
+#else
       g_string_append_printf(str, "%s", interface_opts.descr);
+#endif

is wrong - if the quotes belong there, they belong there on both platforms.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.