Wireshark-bugs: [Wireshark-bugs] [Bug 6603] New: Compilation fails at dumpcap.c:2544 due to unde
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6603
Summary: Compilation fails at dumpcap.c:2544 due to undefined
'sel_ret'
Product: Wireshark
Version: 1.6.4
Platform: x86
OS/Version: Gentoo
Status: NEW
Severity: Normal
Priority: Low
Component: Wireshark
AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
ReportedBy: todd@xxxxxxxxxxxxx
Build Information:
The previous version, which builds OK.
wireshark 1.6.3 (SVN Rev 39702 from /trunk-1.6)
Copyright 1998-2011 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Compiled (32-bit) with GTK+ 2.24.5, with GLib 2.29.14, with libpcap 1.2.0, with
libz 1.2.5, with POSIX capabilities (Linux), without libpcre, without SMI,
without c-ares, without ADNS, without Lua, without Python, without GnuTLS, with
Gcrypt 1.5.0, without Kerberos, without GeoIP, without PortAudio, without
AirPcap.
Running on Linux 3.2.0-rc2, with libpcap version 1.2.0, with libz 1.2.5, Gcrypt
1.5.0.
Built using gcc 4.6.2.
--
In function capture_loop_dispatch, int sel_ret is declared conditional on
"ifndef USE_THREADS". That's how it's used everywhere, except at line 2544,
which is conditional on MUST_DO_SELECT.
--- dumpcap.c.orig 2011-11-21 20:43:36.000000000 -0500
+++ dumpcap.c 2011-11-21 20:44:56.000000000 -0500
@@ -2491,6 +2491,9 @@
#ifndef USE_THREADS
int sel_ret;
#endif
+#ifdef MUST_DO_SELECT
+ int sel_ret;
+#endif
packet_count_before = ld->packet_count;
if (ld->from_cap_pipe) {
Combining the logic of the two looked ugly. It might be better to just declare
it unconditionally and let the compiler warn about the unused variable if it
isn't needed.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
