Wireshark-bugs: [Wireshark-bugs] [Bug 6600] Aastra Signalling Protocol (AASP)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 21 Nov 2011 08:17:05 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6600

--- Comment #4 from Bill Meier <wmeier@xxxxxxxxxxx> 2011-11-21 11:17:00 EST ---
Some addt'l comments:

1. proto_reg_handoff...) should be at the end of the file (to follow the
Wireshark convention).

2. If there are no prefs (as per Jaap's comment) then the "simple" version
   of proto_reg_handoff...() can be used (i.e., without the 'initialized' flag.
   (See doc/README.developer).

3. The proto_tree_add_item() 'encoding' arg for FT_STRINGS should include
   the character encoding which is presumably ENC_ASCII in this case.
   See doc/README.developer under proto_tree_add_item() for all the
   details.

4. Whitespace: The source fie appears to be using a mixture of "4 space tabs"
   4 spaces for indentation. If the intent is to use an indentation of 4,8,...
   please use spaces. See doc/README.developer section 1.1.5

   Also: please remove any trailing whitespace from lines.

5. The "info" (COL_INFO) col is never filled in (but probably should be).
   See README.developer Section 1.2 'Skeleton Code" for details.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.