Wireshark-bugs: [Wireshark-bugs] [Bug 6082] Enhancement of Hilscher Analyzer Dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6082
--- Comment #19 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2011-11-18 05:43:13 PST ---
Hi,
In general I prefere that if a value is number of bits the display will
show which bits make up that value. You would probably only open up that item
if you are interested in the value. That said I won't reject a patch(In reply
to comment #18)
> Before creating a new patch to fix the problems with decoding some fields, I
> would like to clarify if we should use the bit-field variant or the variant
> with proto_tree_add_uint for port number and length.
> I prefer the second variant but as you changed this in my original patch this
> doesn't seem to be the right way to do?
> Please clarify and I will provide the appropriate (and hopefully final :-))
> patch.
Hi,
In general I prefere that if a value is number of bits the display will
show which bits make up that value. You would probably only open up that item
if you are interested in the value and bits. That said I won't reject a patch
changing the current implementation - but I wouldn't have done it that way :-)
Regards
Anders
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
