Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6082] Enhancement of Hilscher Analyzer Dissector

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6082

--- Comment #16 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2011-11-14 07:51:27 PST ---
(In reply to comment #15)
> > 
> > I'm curious as to what's wrong with the length display. Based upon the
> > description in the source file and to match the summary line display, I changed
> > the display using proto_tree_add_item() to be little-endian.
> Looking again: I think I see:
> The display of port & length as it's currently shown is definitely misleading
> since the display implies that both are taken from the same two bytes....
> I'd have to think a bit as to how to best show everything.
> I do think that the version field should be displayed...

Hi,
The code for port should have been:
proto_tree_add_item(netanalyzer_header_tree, hf_netanalyzer_port, tvb, 0, 1,
ENC_LITTLE_ENDIAN);

        { &hf_netanalyzer_port,
          { "Reception Port", "netanalyzer.port",
            FT_UINT8, BASE_DEC, NULL, 0xc0,
            "netANALYZER reception port", HFILL }
        },

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.