Wireshark-bugs: [Wireshark-bugs] [Bug 6562] New: Incorrect Parsing of SCPS Capabilities Option i
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6562
Summary: Incorrect Parsing of SCPS Capabilities Option
introduced in response to bug 6194
Product: Wireshark
Version: SVN
Platform: x86
OS/Version: Mac OS X 10.6
Status: NEW
Severity: Normal
Priority: Low
Component: Wireshark
AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
ReportedBy: eric.dot.travis@xxxxxxxxx
Created an attachment (id=7396)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7396)
Detailed Explanation as to the need for the behavior reversions
Build Information:
Version 1.6.4 (SVN Rev 39780 from /trunk-1.6)
Copyright 1998-2011 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Compiled (32-bit) with GTK+ 2.24.6, with GLib 2.30.0, with libpcap 1.1.1, with
libz 1.2.3.4, with POSIX capabilities (Linux), without libpcre, with SMI 0.4.8,
with c-ares 1.7.4, with Lua 5.1, without Python, with GnuTLS 2.10.5, with
Gcrypt
1.5.0, with MIT Kerberos, with GeoIP, with PortAudio V19-devel (built Jul 27
2011 11:30:44), without AirPcap.
Running on Linux 3.0.0-12-generic-pae, with libpcap version 1.1.1, with libz
1.2.3.4, GnuTLS 2.10.5, Gcrypt 1.5.0.
Built using gcc 4.6.1.
--
The patch accompanying bug 6194 introduced a few problems related to the proper
(conformance to specification) handling of the SCPS Capabilities and SCPS
Extended Capabilities option for TCP.
This patch corrects the following:
1 - Restores the ordering of the reserved bits to that defined in the
specification
2 - Restores the minimum option length to 4 octets.
3 - Restores the behavior of clearing the flow->scps_capable field
if both parties have not negotiated the use of SCPS capabilities
during connection establishment.
4 - Restores the labeling of the "Binding Space ID" - removing the
"Community" tag as Binding fields may be assigned to communities
of interest of vendors. This is indeed a nit, but the reversion
is more representative of intent.
Attached are:
o A more detailed discussion of why these modifications are appropriate
(as the comments in the original [pre-bug 6194] code were not sufficient.
o Diffs for both the stable and unstable subversion code trees
o The pcap file used for reporting bug 6194. This serves to illustrate
the flawed protocol implementation behavior that this patch corrects.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
