Wireshark-bugs: [Wireshark-bugs] [Bug 6538] Addressing Clang-Code-Analysis build warnings for op
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 3 Nov 2011 00:41:15 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6538

Roland Knall <rknall@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7359|review_for_checkin?         |
               Flag|                            |
   Attachment #7359|0                           |1
        is obsolete|                            |
   Attachment #7360|                            |review_for_checkin?
               Flag|                            |

--- Comment #6 from Roland Knall <rknall@xxxxxxxxx> 2011-11-03 00:41:11 PDT ---
Created an attachment (id=7360)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7360)
Removes stringToBytes and use hex_str_to_bytes instead

The attached patch removes stringToBytes as well as opensafety_get_scm_udid, as
it is not needed anymore. Instead hex_str_to_bytes is used.

The patch has been fuzz-tested and randpkt tested.

What will follow is a move of the crc16 and crc8 tables to wsutil, but for this
I have to compare the already existing implementations in wsutil for crc16.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.