Wireshark-bugs: [Wireshark-bugs] [Bug 6538] Addressing Clang-Code-Analysis build warnings for op
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 2 Nov 2011 23:36:01 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6538

--- Comment #3 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2011-11-02 23:36:00 PDT ---
(In reply to comment #2)
> Why is the code in stringToBytes() so badly written C code?
> This has to be rewritten with proper code.
> 

Can hex_str_to_bytes() in strutil.h be used?

> Why does this dissector have it's own crc routines?
> They should be moved to wsutil.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.