https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6416
--- Comment #20 from Michael Mann <mmann78@xxxxxxxxxxxx> 2011-10-25 19:48:06 PDT ---
(In reply to comment #15)
> A couple other comments:
> 1) Shouldn't the tvb_length_remaining() calls be
> tvb_reported_length_remaining()? At least the ones checking for how much data
> is left before raising an expert info--since having a capture cut short by a
> snaplen is does not a malformed packet make (it makes a truncated packet).
> Another related question is whether those checks are really necessary: if they
> weren't there the dissector would walk off the end of the TVB and throw the
> appropriate exception.
I can make the changes for tvb_reported_length_remaining(), but the issue I've
run into is that when the exception is thrown some already dissected fields
were "discarded", I think to the top of the subtree where the item that walked
off the end was being added to. Since this dissector used to have a larger
amount of proto_tree_add_texts instead of proto_tree_add_items perhaps that was
the real reason fields were being discarded, but I was trying to prevent those
cases again.
> 2) Double check the encoding values. For example hf_cip_link_address_string is
> used with ENC_LITTLE_ENDIAN; that should probably be ENC_ASCII|ENC_NA.
I'm going to chalk this one up to the patch not applying cleanly because my
code (and the patch from what I can see) has hf_cip_link_address_string with a
ENC_ASCII|ENC_NA encoding.
> 3) This:
> + expert_add_info_format(pinfo, item, PI_UNDECODED, PI_ERROR, "PROGRAMMING
> ERROR: Attribute table set up incorrectly");
> Should probably be a DISSECTOR_ASSERT() since it appears to really be a
> programming error (not a problem with the packet). That way our automated fuzz
> testing will detect if/when we hit that situation.
Done
> 4) tvb_get_ephemeral_faked_unicode() has been superseded by
> tvb_get_ephemeral_string().
Done
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
