Wireshark-bugs: [Wireshark-bugs] [Bug 6443] packet-ieee80211.c enhancements and cleanup
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6443
--- Comment #17 from Jouni Malinen <j@xxxxx> 2011-10-11 15:41:36 PDT ---
(In reply to comment #16)
> (In reply to comment #9)
> > Created an attachment (id=7212)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7212) [details]
[details]
> > (UNTESTED) ieee80211: Move sniffer meta data parsing to separate files
> I'm inclined to check it in as I think it's the right thing to do, any
> objections?
I was hoping to find couple of capture files first to verify that I did not
break anything. While searching for samples, I came up something else though..
It looks like these sniffer dissectors were indeed in their separate files
originally (packet-wlancap.c and packet-prism.c) and somehow then got merged
into packet-ieee80211.c.. The commit to do that is from a few years back:
"r23911 | guy | 2007-12-18 10:01:11 +0200 (Tue, 18 Dec 2007) | 7 lines
Fold the Prism and AVS header dissectors into packet-ieee80211.c, and
have them use least some of the radio-information fields, so that the
same field name can be used for multiple radio header types. The AVS
header can supply the data rate in bits/second, so have that field be in
those units, and make it 64 bits to leave room for the future, Just In
Case. Display it as Mb/s, however."
I don't think I would agree with this justification, though, but just wanted to
point out that now that I ended up figuring out what the history for this was..
Though, it should also be noted that Prism 2 -based devices are pretty ancient
at this point and as such, there is even more justification to move this more
or less obsolete code away from packet-ieee80211.c in my opinion.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
