Wireshark-bugs: [Wireshark-bugs] [Bug 5929] New protocol dissector for "CIP Motion"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5929
--- Comment #18 from Benjamin Stocks <bmstocks@xxxxxxxxxxxxxxx> 2011-10-11 08:13:41 PDT ---
Patch updated and attached. Comments addressed include:
> 1. There's no prefs so prefs_register_protoco() need not be called (and
> #include <prefs.h> is not needed, etc.
DONE
> also: proto_reg_handoff...() doesn't need 'if (!initialized) ...' since no
> prefs and thus this fcn is only called at Wireshark startup.
DONE
> cip_motion_handle isn't actually used so no need to call
> create_dissector_handle()
DONE
> 2. Forward ref declaration for proto_register...() not needed.
DONE
> To elaborate: You need to put "$Id" in the file to start and then the
DONE
> If a (large) value_string array is needed in more than one dissector source
> file just have an static instance of the value_string array in one .c file and
> then define a public value_string_ext pointer which is referenced as needed.
DONE, packet-cip.c and packet-cipmotion.c share the same value string already
defined in packet-cip.c. I left cip_gs_vals in the value_string format it
already is in packet-cip.c, I don't have access to enough packet captures to
really test a change in the generic CIP dissector.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
