Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 6324] patch for bgp mcast-vpn nlri dissection

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6324

Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6985|review_for_checkin?         |review_for_checkin-
               Flag|                            |

--- Comment #4 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2011-10-01 06:33:48 PDT ---
(From update of attachment 6985)
Hi

1) Update the patch from trunk (SVN)
2) Use the consistent identation ( 4 spaces and not tab)
3)
+        case FORMAT_IP_LOC:
+            ip4addr = tvb_get_ipv4(tvb, offset + 2);
+            ep_strbuf_printf(strbuf, "%s:%u", ip_to_str((guint8 *)&ip4addr),
+                             tvb_get_ntohs(tvb, offset + 6));
Use tvb_ip_to_str function to display IPv4 Address

4)
+        item = proto_tree_add_item(tree, hf_bgp_mcast_vpn_nlri_source_addr,
tvb,
+                                   offset, 4, ENC_NA);
+        proto_item_set_text(item, "Source Address: %s",
+                            ip_to_str((guint8*) &addr4));
[...]
+      { &hf_bgp_mcast_vpn_nlri_source_addr,
+        { "Source Address", "bgp.mcast_vpn_nlri_source_as", FT_BYTES,
+          BASE_NONE, NULL, 0x0, NULL, HFILL}},
Use FT_IPv4 header field (hf) type to display directly IPv4 address (and make
filterable)
5) There is some Clang Warning about not used offset in function
decode_mcast_vpn_nlri

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.